WIP: [Storage] Refactor test_clone tests to remove DV wait usage by ema-aka-young · Pull Request #4605 · RedHatQE/openshift-virtualization-tests

ema-aka-young · 2026-04-27T10:41:06Z

Short description:

Removing DataVolume wait usage to allow us to remove it from the wrapper. Using wait_for_dv_success() instead.

More details:

Part of this task's work https://redhat.atlassian.net/browse/CNV-73197

What this PR does / why we need it:

To abandon DataVolume wait(), which will be deprecated.

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Summary by CodeRabbit

Tests
- Improved test efficiency and reliability for data volume operations during VM restart scenarios.

…sage and utilize create_dv for DataVolume creation Signed-off-by: Emanuele Prella <eprella@redhat.com>

coderabbitai · 2026-04-27T10:41:13Z

📝 Walkthrough

Walkthrough

Test simplification in test_successful_vm_restart_with_cloned_dv refactors data volume creation to use the create_dv helper method, consolidates separate wait operations into a single wait_for_dv_success() call, and removes an unused import.

Changes

Cohort / File(s)	Summary
Test Refactoring `tests/storage/cdi_clone/test_clone.py`	Replaced direct `DataVolume` instantiation with `create_dv` helper (removing explicit `api_name="storage"` parameter). Consolidated two-step wait logic (checking DV existence, then PVC) into single `cdv.wait_for_dv_success()` call. Removed unused `TIMEOUT_1MIN` import.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The pull request description follows the required template with all key sections completed: short description, more details with task reference, purpose statement, and appropriate handling of issue/ticket fields.
Title check	✅ Passed	The title accurately describes the main change: refactoring test_clone tests to remove DataVolume wait usage and migrate to the create_dv helper function.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-virtualization-qe-bot-4 · 2026-04-28T08:37:09Z

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
Branch Labeling: Branch-specific labels are applied to track the target branch
Auto-verification: Auto-verified users have their PRs automatically marked as verified
Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

/wip - Mark PR as work in progress (adds WIP: prefix to title)
/wip cancel - Remove work in progress status
/hold - Block PR merging (approvers only)
/hold cancel - Unblock PR merging
/verified - Mark PR as verified
/verified cancel - Remove verification status
/reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
/regenerate-welcome - Regenerate this welcome message

Review & Approval

/lgtm - Approve changes (looks good to me)
/approve - Approve PR (approvers only)
/assign-reviewers - Assign reviewers based on OWNERS file
/assign-reviewer @username - Assign specific reviewer
/check-can-merge - Check if PR meets merge requirements

Testing & Validation

/retest tox - Run Python test suite with tox
/retest build-container - Rebuild and test container image
/retest verify-bugs-are-open - verify-bugs-are-open
/retest all - Run all available tests

Container Operations

/build-and-push-container - Build and push container image (tagged with PR number)
- Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

/cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
- Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

/<label-name> - Add a label to the PR
/<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

Approval: /approve from at least one approver
LGTM Count: Minimum 2 /lgtm from reviewers
Status Checks: All required status checks must pass
No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

jpeimer

Reviewers:

Ahmad-Hafe
acinko-rh
dalia-frank
ema-aka-young
josemacassan
jpeimer
kgoldbla
kshvaika

Available Labels

hold
verified
wip
lgtm
approve

AI Features

Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6[1m])

💡 Tips

WIP Status: Use /wip when your PR is not ready for review
Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
Cherry-picking: Cherry-pick labels are processed when the PR is merged
Container Builds: Container images are automatically tagged with the PR number
Permission Levels: Some commands require approver permissions
Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

jpeimer · 2026-04-28T08:52:13Z

-
-    with DataVolume(
-        name="dv-target",
+    with create_dv(


There may be an issue with WFFC storage.

create_dv() creates a first consumer pod, which may put a PVC on a certain node, and if this node cannot accommodate our future VM, VM will never be scheduled.
The expected WFFC flow is to create a DV, leave it without the consumer, and then VM that wants to use it becomes its first consumer.

Got it, thank you. I'll revert this change.

@jpeimer After some investigation, I noticed we could avoid having the dummy consumer pod setting consume_wffc to False

openshift-virtualization-tests/utilities/storage.py

Line 172 in 86f63e3

if sc_volume_binding_mode_is_wffc(sc=storage_class, client=client) and consume_wffc:

And we could have a conditional wait for DV success or pending population, depending on the storage class binding. Like we have in

openshift-virtualization-tests/tests/storage/cdi_import/conftest.py

Lines 163 to 166 in 86f63e3

if sc_volume_binding_mode_is_wffc(sc=storage_class_name_scope_module, client=unprivileged_client):

dv.wait_for_status(status=DataVolume.Status.PENDING_POPULATION, timeout=TIMEOUT_1MIN)

else:

dv.wait_for_dv_success(timeout=TIMEOUT_1MIN)

What do you think of this approach?

ema-aka-young · 2026-04-28T10:39:13Z

/wip

Refactor test_successful_vm_restart_with_cloned_dv to remove dvwait u…

ded4641

…sage and utilize create_dv for DataVolume creation Signed-off-by: Emanuele Prella <eprella@redhat.com>

github-actions Bot added the sig-storage label Apr 27, 2026

ema-aka-young changed the title ~~Refactor test_successful_vm_restart_with_cloned_dv to remove dvwait usage and utilize create_dv for DataVolume creation~~ Refactor test_clone to remove DV wait usage Apr 27, 2026

openshift-virtualization-qe-bot added tox:verify-tc-requirement-polarion:running D/S Testing tox:verify-tc-requirement-polarion:passed D/S Testing needs-rebase and removed tox:verify-tc-requirement-polarion:running D/S Testing labels Apr 27, 2026

ema-aka-young changed the title ~~Refactor test_clone to remove DV wait usage~~ [Storage] Refactor test_clone to remove DV wait usage Apr 28, 2026

ema-aka-young changed the title ~~[Storage] Refactor test_clone to remove DV wait usage~~ [Storage] Refactor test_clone tests to remove DV wait usage and use create_dv Apr 28, 2026

ema-aka-young marked this pull request as ready for review April 28, 2026 08:36

openshift-virtualization-qe-bot-4 requested a review from kshvaika April 28, 2026 08:37

openshift-virtualization-qe-bot-4 assigned ema-aka-young Apr 28, 2026

openshift-virtualization-qe-bot-4 mentioned this pull request Apr 28, 2026

[Storage] Refactor test_clone tests to remove DV wait usage and use create_dv - 4605 #4621

Open

openshift-virtualization-qe-bot-4 requested a review from jpeimer April 28, 2026 08:37

openshift-virtualization-qe-bot-4 added the branch-main label Apr 28, 2026

openshift-virtualization-qe-bot-4 requested review from Ahmad-Hafe, josemacassan and kgoldbla April 28, 2026 08:37

openshift-virtualization-qe-bot-4 added the size/XS label Apr 28, 2026

openshift-virtualization-qe-bot-4 requested review from acinko-rh and dalia-frank April 28, 2026 08:38

coderabbitai Bot approved these changes Apr 28, 2026

View reviewed changes

openshift-virtualization-qe-bot-4 added the lgtm-coderabbitai[bot] label Apr 28, 2026

jpeimer reviewed Apr 28, 2026

View reviewed changes

jpeimer requested changes Apr 28, 2026

View reviewed changes

openshift-virtualization-qe-bot-2 added the commented-jpeimer label Apr 28, 2026

openshift-virtualization-qe-bot-5 added the changes-requested-jpeimer label Apr 28, 2026

openshift-virtualization-qe-bot-2 added the commented-ema-aka-young label Apr 28, 2026

ema-aka-young changed the title ~~[Storage] Refactor test_clone tests to remove DV wait usage and use create_dv~~ [Storage] Refactor test_clone tests to remove DV wait usage Apr 28, 2026

openshift-virtualization-qe-bot added the wip label Apr 28, 2026

openshift-virtualization-qe-bot changed the title ~~[Storage] Refactor test_clone tests to remove DV wait usage~~ WIP: [Storage] Refactor test_clone tests to remove DV wait usage Apr 28, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: [Storage] Refactor test_clone tests to remove DV wait usage#4605

WIP: [Storage] Refactor test_clone tests to remove DV wait usage#4605
ema-aka-young wants to merge 1 commit intoRedHatQE:mainfrom
ema-aka-young:cnv-73917-remove-dvwait-usage

ema-aka-young commented Apr 27, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Apr 27, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-virtualization-qe-bot-4 commented Apr 28, 2026

Uh oh!

jpeimer Apr 28, 2026

Uh oh!

ema-aka-young Apr 28, 2026 •

edited

Loading

Uh oh!

ema-aka-young Apr 28, 2026 •

edited

Loading

Uh oh!

ema-aka-young commented Apr 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	if sc_volume_binding_mode_is_wffc(sc=storage_class_name_scope_module, client=unprivileged_client):
	dv.wait_for_status(status=DataVolume.Status.PENDING_POPULATION, timeout=TIMEOUT_1MIN)
	else:
	dv.wait_for_dv_success(timeout=TIMEOUT_1MIN)

Conversation

ema-aka-young commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Short description:

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-virtualization-qe-bot-4 commented Apr 28, 2026

Welcome! 🎉

🔄 Automatic Actions

📋 Available Commands

PR Status Management

Review & Approval

Testing & Validation

Container Operations

Cherry-pick Operations

Label Management

✅ Merge Requirements

📊 Review Process

💡 Tips

Uh oh!

jpeimer Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

ema-aka-young Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ema-aka-young Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ema-aka-young commented Apr 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ema-aka-young commented Apr 27, 2026 •

edited

Loading

coderabbitai Bot commented Apr 27, 2026 •

edited

Loading

ema-aka-young Apr 28, 2026 •

edited

Loading

ema-aka-young Apr 28, 2026 •

edited

Loading